-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stream.resume() doesn't make the stream flowing after removing readable listener #24281
Labels
Comments
@nodejs/streams |
Hey @snakamura! As per the docs -
So if you remove your |
@shobhitchittora That's what I expected, and v10.13.0 didn't work like that as you can see in my code. |
Confirmed, we need to have a look in more detail. |
mcollina
added a commit
to mcollina/node
that referenced
this issue
Nov 14, 2018
3 tasks
Check out #24366. |
Fixed in 69cc58d. |
mcollina
added a commit
that referenced
this issue
Nov 21, 2018
Fixes: #24281 PR-URL: #24366 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
targos
pushed a commit
that referenced
this issue
Nov 21, 2018
Fixes: #24281 PR-URL: #24366 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Thank you! |
rvagg
pushed a commit
that referenced
this issue
Nov 28, 2018
Fixes: #24281 PR-URL: #24366 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
@nodejs/backporters Sorry to bother you, but are there chances that this fix will be backported to 10.x LTS? |
codebytere
pushed a commit
that referenced
this issue
Jan 13, 2019
Fixes: #24281 PR-URL: #24366 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
refack
pushed a commit
to refack/node
that referenced
this issue
Jan 14, 2019
Fixes: nodejs#24281 PR-URL: nodejs#24366 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
codebytere
pushed a commit
that referenced
this issue
Jan 29, 2019
Fixes: #24281 PR-URL: #24366 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
With v10.13.0, stream.resume() doesn't make the stream flowing after removing
readable
listener. Here is a code to demonstrate the problem.Note that you need to name this script
s.js
to run this script without any changes.With v10.13.0, this prints nothing. With v8.12.0, this prints
end
. This seems to be related to #18994, #21696 and #22209, but I'm not sure if this is an intentional change.Note that a stream starts flowing when I add
data
listener instead of callingresume
.The text was updated successfully, but these errors were encountered: