Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test test-net-socket-local-address #2475

Closed
joaocgreis opened this issue Aug 20, 2015 · 4 comments
Closed

Investigate flaky test test-net-socket-local-address #2475

joaocgreis opened this issue Aug 20, 2015 · 4 comments
Labels
build Issues and PRs related to build files or the CI. freebsd Issues and PRs related to the FreeBSD platform. test Issues and PRs related to the tests.

Comments

@joaocgreis
Copy link
Member

Examples of failures:
@joaocgreis joaocgreis added build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. labels Aug 20, 2015
@brendanashworth brendanashworth added the freebsd Issues and PRs related to the FreeBSD platform. label Aug 21, 2015
@brendanashworth
Copy link
Contributor

ref to #2464

@Trott
Copy link
Member

Trott commented Nov 23, 2015

Would it make sense to add code that skips the test if it is being run in a FreeBSD jail? Or is the jail not really the problem here? /cc @jbergstroem

Trott added a commit to Trott/io.js that referenced this issue Nov 24, 2015
@Trott
test: skip test if in FreeBSD jail
1d526bf 
Fixes: nodejs#2475
@Trott Trott mentioned this issue Nov 24, 2015
Closed
@Trott Trott closed this as completed in b061e3a Nov 25, 2015
@Trott
Copy link
Member

Trott commented Nov 25, 2015

Still flaky: https://ci.nodejs.org/job/node-test-commit-freebsd/405/nodes=freebsd102-64/console:

not ok 565 test-net-socket-local-address.js
# TIMEOUT

Reopening.

@Trott Trott reopened this Nov 25, 2015
Trott added a commit to Trott/io.js that referenced this issue Nov 25, 2015
@Trott
test: mark test flaky on FreeBSD
ef07dcc 
Mark test-net-socket-local-address flaky on FreeBSD. It times out with
some frequency on CI.

Ref: nodejs#2475
@Trott Trott mentioned this issue Nov 25, 2015
Closed
Trott added a commit to Trott/io.js that referenced this issue Nov 27, 2015
@Trott
test: mark test flaky on FreeBSD
e25f868 
Mark test-net-socket-local-address flaky on FreeBSD. It times out with
some frequency on CI.

Ref: nodejs#2475
PR-URL: nodejs#4016
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Trott added a commit to Trott/io.js that referenced this issue Nov 27, 2015
@Trott
test: fix race in test-net-socket-local-address
c8b7437 
test-net-socket-local-address had a race condition that resulted in
unreliability on FreeBSD. This changes fixes the issue.

Fixes: nodejs#2475
@Trott Trott mentioned this issue Nov 27, 2015
Closed
@Trott
Copy link
Member

Trott commented Nov 27, 2015

Should be fixed (for real this time, I hope) in #4052

@bnoordhuis bnoordhuis mentioned this issue Nov 30, 2015
Closed
Trott added a commit that referenced this issue Dec 1, 2015
@Trott
test: skip test if in FreeBSD jail
5702eef 
Test test-net-socket-local-address is flaky in FreeBSD jail but robust
otherwise.

Fixes: #2475
PR-URL: #3995
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Trott added a commit that referenced this issue Dec 1, 2015
@Trott
test: mark test flaky on FreeBSD
d7637c9 
Mark test-net-socket-local-address flaky on FreeBSD. It times out with
some frequency on CI.

Ref: #2475
PR-URL: #4016
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@Trott Trott mentioned this issue Dec 1, 2015
Closed
Trott added a commit to Trott/io.js that referenced this issue Dec 1, 2015
@Trott
test: fix flaky test-net-socket-local-address
6dbc8a8 
test-net-socket-local-address had a race condition that resulted in
unreliability on FreeBSD and Windows. This changes fixes the issue.

Fixes: nodejs#2475
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Dec 1, 2015
@bnoordhuis
test: fix parallel/test-net-socket-local-address
840e533 
Fix flakiness where the client sometimes closed the server before the
server had the chance to process the outstanding client connection.
Make the server close itself instead.

Fixes: nodejs#2475
@Trott Trott closed this as completed in c79b145 Dec 3, 2015
Trott added a commit that referenced this issue Dec 4, 2015
@Trott @rvagg
test: skip test if in FreeBSD jail
d184c70 
Test test-net-socket-local-address is flaky in FreeBSD jail but robust
otherwise.

Fixes: #2475
PR-URL: #3995
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Trott added a commit that referenced this issue Dec 4, 2015
@Trott @rvagg
test: mark test flaky on FreeBSD
7c528b7 
Mark test-net-socket-local-address flaky on FreeBSD. It times out with
some frequency on CI.

Ref: #2475
PR-URL: #4016
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Trott added a commit that referenced this issue Dec 5, 2015
@Trott @rvagg
test: skip test if in FreeBSD jail
19ed33d 
Test test-net-socket-local-address is flaky in FreeBSD jail but robust
otherwise.

Fixes: #2475
PR-URL: #3995
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Trott added a commit that referenced this issue Dec 5, 2015
@Trott @rvagg
test: mark test flaky on FreeBSD
c500037 
Mark test-net-socket-local-address flaky on FreeBSD. It times out with
some frequency on CI.

Ref: #2475
PR-URL: #4016
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Trott added a commit that referenced this issue Dec 5, 2015
@Trott @rvagg
test: fix flaky test-net-socket-local-address
4b43bf0 
test-net-socket-local-address had a race condition that resulted in
unreliability on FreeBSD and Windows. This changes fixes the issue.

Fixes: #2475
PR-URL: #4109
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Trott added a commit that referenced this issue Dec 17, 2015
@Trott @jasnell
test: skip test if in FreeBSD jail
38ba152 
Test test-net-socket-local-address is flaky in FreeBSD jail but robust
otherwise.

Fixes: #2475
PR-URL: #3995
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Trott added a commit that referenced this issue Dec 17, 2015
@Trott @jasnell
test: mark test flaky on FreeBSD
4ea1a69 
Mark test-net-socket-local-address flaky on FreeBSD. It times out with
some frequency on CI.

Ref: #2475
PR-URL: #4016
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Trott added a commit that referenced this issue Dec 23, 2015
@Trott @jasnell
test: skip test if in FreeBSD jail
f516200 
Test test-net-socket-local-address is flaky in FreeBSD jail but robust
otherwise.

Fixes: #2475
PR-URL: #3995
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Trott added a commit that referenced this issue Dec 23, 2015
@Trott @jasnell
test: mark test flaky on FreeBSD
f738fe4 
Mark test-net-socket-local-address flaky on FreeBSD. It times out with
some frequency on CI.

Ref: #2475
PR-URL: #4016
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Trott added a commit that referenced this issue Dec 29, 2015
@Trott
test: fix flaky test-net-socket-local-address
f634ab6 
test-net-socket-local-address had a race condition that resulted in
unreliability on FreeBSD and Windows. This changes fixes the issue.

Fixes: #2475
PR-URL: #4109
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
MylesBorins pushed a commit that referenced this issue Jan 19, 2016
@Trott
test: fix flaky test-net-socket-local-address
c9100d7 
test-net-socket-local-address had a race condition that resulted in
unreliability on FreeBSD and Windows. This changes fixes the issue.

Fixes: #2475
PR-URL: #4109
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this issue Apr 2, 2016
@Trott
test: skip test if in FreeBSD jail
56efb3d 
Test test-net-socket-local-address is flaky in FreeBSD jail but robust
otherwise.

Fixes: nodejs#2475
PR-URL: nodejs#3995
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this issue Apr 2, 2016
@Trott
test: mark test flaky on FreeBSD
ba05f2a 
Mark test-net-socket-local-address flaky on FreeBSD. It times out with
some frequency on CI.

Ref: nodejs#2475
PR-URL: nodejs#4016
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this issue Apr 2, 2016
@Trott
test: fix flaky test-net-socket-local-address
19c8af2 
test-net-socket-local-address had a race condition that resulted in
unreliability on FreeBSD and Windows. This changes fixes the issue.

Fixes: nodejs#2475
PR-URL: nodejs#4109
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. freebsd Issues and PRs related to the FreeBSD platform. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
3 participants
@joaocgreis @Trott @brendanashworth