Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate flaky test-child-process-execFile #25029

Closed
Trott opened this issue Dec 14, 2018 · 4 comments
Closed

Investigate flaky test-child-process-execFile #25029

Trott opened this issue Dec 14, 2018 · 4 comments
Labels
aix Issues and PRs related to the AIX platform. child_process Issues and PRs related to the child_process subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI.

Comments

@Trott
Copy link
Member

Trott commented Dec 14, 2018

https://ci.nodejs.org/job/node-test-commit-aix/19688/nodes=aix61-ppc64/consoleText

test-osuosl-aix61-ppc64_be-1

ot ok 217 parallel/test-child-process-execfile
  ---
  duration_ms: 4.640
  severity: fail
  exitcode: 1
  stack: |-
    assert.js:86
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
    
    null !== 42
    
        at common.mustCall (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-child-process-execfile.js:20:14)
        at /home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/common/index.js:335:15
        at ChildProcess.exithandler (child_process.js:301:5)
        at ChildProcess.emit (events.js:189:13)
        at maybeClose (internal/child_process.js:978:16)
        at Process.ChildProcess._handle.onexit (internal/child_process.js:265:5)
  ...
@Trott Trott added child_process Issues and PRs related to the child_process subsystem. aix Issues and PRs related to the AIX platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Dec 14, 2018
@gireeshpunathil
Copy link
Member

I will investigate this too when I get CI access through nodejs/build#1637

@Trott
Copy link
Member Author

Trott commented Dec 14, 2018

Same test dumped core on ubuntu1604_sharedlibs_debug_x64:

test-digitalocean-ubuntu1604_sharedlibs_container-x64-8

https://ci.nodejs.org/job/node-test-commit-linux-containered/9419/nodes=ubuntu1604_sharedlibs_debug_x64/consoleText

not ok 267 parallel/test-child-process-execfile
  ---
  duration_ms: 1.439
  severity: fail
  exitcode: 1
  stack: |-
    assert.js:753
        throw newErr;
        ^
    
    AssertionError [ERR_ASSERTION]: ifError got unwanted exception: Command failed: /home/iojs/build/workspace/node-test-commit-linux-containered/out/Debug/node /home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/exit.js 0
    Segmentation fault (core dumped)
    
        at ChildProcess.exithandler (child_process.js:294:12)
        at ChildProcess.emit (events.js:189:13)
        at maybeClose (internal/child_process.js:978:16)
        at Socket.stream.socket.on (internal/child_process.js:396:11)
        at Socket.emit (events.js:189:13)
        at Pipe._handle.close (net.js:612:12)
  ...

@Trott Trott changed the title Investigate flaky test-child-process-execFile on AIX Investigate flaky test-child-process-execFile Dec 14, 2018
Trott added a commit to Trott/io.js that referenced this issue Dec 14, 2018
Trott added a commit to Trott/io.js that referenced this issue Dec 15, 2018
Refs: nodejs#25029

PR-URL: nodejs#25051
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
BethGriggs pushed a commit that referenced this issue Dec 18, 2018
Refs: #25029

PR-URL: #25051
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@gireeshpunathil
Copy link
Member

got one core file in 40th iteration, in the CI.

0x110378be0 (???) 00000000       Invalid opcode.
(dbx) where
.() at 0x110378be0
array-buffer-collector._ZN2v88internal20CancelableLambdaTaskIZNS0_20ArrayBufferCollector15FreeAllocationsEvEUlvE_E11RunInternalEv(??) at 0x1011caca4
_ZN2v88internal14CancelableTask3RunEv(??) at 0x100039304
node_platform._ZN4node12_GLOBAL__N_1L20PlatformWorkerThreadEPv(??) at 0x1001e6970
(dbx) 

did not bother to debug further - needless to say, this is same as described in #25007

Mark as flaky, wait till #25007 is resolved is the way forward.

gireeshpunathil added a commit to gireeshpunathil/node that referenced this issue Dec 19, 2018
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in nodejs#25007
Mart these  as flaky in AIX until that is resolved.

Refs: nodejs#25047
Refs: nodejs#25029
sagitsofan pushed a commit to sagitsofan/node that referenced this issue Dec 24, 2018
Refs: nodejs#25029

PR-URL: nodejs#25051
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
gireeshpunathil added a commit that referenced this issue Dec 28, 2018
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart these  as flaky in AIX until that is resolved.

Refs: #25047
Refs: #25029

PR-URL: #25126
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
targos pushed a commit that referenced this issue Jan 1, 2019
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart these  as flaky in AIX until that is resolved.

Refs: #25047
Refs: #25029

PR-URL: #25126
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
refack pushed a commit to refack/node that referenced this issue Jan 14, 2019
Refs: nodejs#25029

PR-URL: nodejs#25051
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
refack pushed a commit to refack/node that referenced this issue Jan 14, 2019
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in nodejs#25007
Mart these  as flaky in AIX until that is resolved.

Refs: nodejs#25047
Refs: nodejs#25029

PR-URL: nodejs#25126
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@gireeshpunathil
Copy link
Member

the test is active for the last one week with no failures, so as expected #25061 has fixed the underlying issue. Closing.

BethGriggs pushed a commit that referenced this issue Feb 12, 2019
Refs: #25029

PR-URL: #25051
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
BethGriggs pushed a commit that referenced this issue Feb 20, 2019
Refs: #25029

PR-URL: #25051
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
rvagg pushed a commit that referenced this issue Feb 28, 2019
Refs: #25029

PR-URL: #25051
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
BethGriggs pushed a commit that referenced this issue Apr 17, 2019
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart these  as flaky in AIX until that is resolved.

Refs: #25047
Refs: #25029

PR-URL: #25126
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
BethGriggs pushed a commit that referenced this issue Apr 28, 2019
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart these  as flaky in AIX until that is resolved.

Refs: #25047
Refs: #25029

PR-URL: #25126
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
BethGriggs pushed a commit that referenced this issue May 10, 2019
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart these  as flaky in AIX until that is resolved.

Refs: #25047
Refs: #25029

PR-URL: #25126
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins pushed a commit that referenced this issue May 16, 2019
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart these  as flaky in AIX until that is resolved.

Refs: #25047
Refs: #25029

PR-URL: #25126
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aix Issues and PRs related to the AIX platform. child_process Issues and PRs related to the child_process subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI.
Projects
None yet
Development

No branches or pull requests

2 participants