Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flake test-worker-debug on ubuntu shared libs #28299

Closed
sam-github opened this issue Jun 19, 2019 · 1 comment
Closed

Investigate flake test-worker-debug on ubuntu shared libs #28299

sam-github opened this issue Jun 19, 2019 · 1 comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. linux Issues and PRs related to the Linux platform. worker Issues and PRs related to Worker support.

Comments

@sam-github
Copy link
Contributor

Flakes below. May be flaky on other platforms, post here if anyone sees that.

See: #28232 (comment)

13:09:51 not ok 2248 parallel/test-worker-debug
13:09:51   ---
13:09:51   duration_ms: 0.917
13:09:51   severity: fail
13:09:51   exitcode: 1
13:09:51   stack: |-
13:09:51     Test basic debug scenario
13:09:51     This is a message from a worker
13:09:51     Test disabling attach to workers
13:09:51     This is a message from a worker
13:09:51     Test disabled waitForDebuggerOnStart
13:09:51     Test attach to a running worker and then start a new one
13:09:51     This is a message from a worker
13:09:51     Test NodeRuntime.waitForDisconnect in worker
13:09:51     Mismatched noop function calls. Expected exactly 1, actual 0.
13:09:51         at Object.mustCall (/home/iojs/build/workspace/node-test-commit-linux-containered/test/common/index.js:340:10)
13:09:51         at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-worker-debug.js:275:18)
13:09:51         at Module._compile (internal/modules/cjs/loader.js:779:30)
13:09:51         at Object.Module._extensions..js (internal/modules/cjs/loader.js:790:10)
13:09:51         at Module.load (internal/modules/cjs/loader.js:642:32)
13:09:51         at Function.Module._load (internal/modules/cjs/loader.js:555:12)
13:09:51         at Function.Module.runMain (internal/modules/cjs/loader.js:842:10)
13:09:51         at internal/main/run_main_module.js:17:11
13:09:51   ...

12:25:32 not ok 2186 parallel/test-worker-debug
12:25:32   ---
12:25:32   duration_ms: 1.343
12:25:32   severity: fail
12:25:32   exitcode: 1
12:25:32   stack: |-
12:25:32     Test basic debug scenario
12:25:32     This is a message from a worker
12:25:32     Test disabling attach to workers
12:25:32     This is a message from a worker
12:25:32     Test disabled waitForDebuggerOnStart
12:25:32     Test attach to a running worker and then start a new one
12:25:32     This is a message from a worker
12:25:32     Test NodeRuntime.waitForDisconnect in worker
12:25:32     Mismatched noop function calls. Expected exactly 1, actual 0.
12:25:32         at Object.mustCall (/home/iojs/build/workspace/node-test-commit-linux-containered/test/common/index.js:340:10)
12:25:32         at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-worker-debug.js:275:18)
12:25:32         at Module._compile (internal/modules/cjs/loader.js:779:30)
12:25:32         at Object.Module._extensions..js (internal/modules/cjs/loader.js:790:10)
12:25:32         at Module.load (internal/modules/cjs/loader.js:642:32)
12:25:32         at Function.Module._load (internal/modules/cjs/loader.js:555:12)
12:25:32         at Function.Module.runMain (internal/modules/cjs/loader.js:842:10)
12:25:32         at internal/main/run_main_module.js:17:11
12:25:32   ...
@sam-github sam-github added flaky-test Issues and PRs related to the tests with unstable failures on the CI. worker Issues and PRs related to Worker support. linux Issues and PRs related to the Linux platform. labels Jun 19, 2019
@sam-github
Copy link
Contributor Author

Possibly related to #28106

sam-github added a commit to sam-github/node that referenced this issue Jun 19, 2019
@sam-github
test: skip test-worker-debug as flaky for linux
511eb2a 
See: nodejs#28299
@sam-github sam-github mentioned this issue Jun 19, 2019
Closed
4 tasks
addaleax added a commit to addaleax/node that referenced this issue Jun 19, 2019
@addaleax
test: fix flaky test-worker-debug
441fc92 
Address a race condition in the test; the Worker’s exit events
may have been not recorded because the Worker exited before
the listeners were attached.

Fix the by attaching the event listeners before telling the Worker
to exit.

Fixes: nodejs#28299
Fixes: nodejs#28106
@addaleax addaleax mentioned this issue Jun 19, 2019
Closed
3 tasks
@danbev danbev closed this as completed in 2dec0f9 Jun 20, 2019
targos pushed a commit that referenced this issue Jul 2, 2019
@addaleax @targos
test: fix flaky test-worker-debug
c44db7f 
Address a race condition in the test; the Worker’s exit events
may have been not recorded because the Worker exited before
the listeners were attached.

Fix the by attaching the event listeners before telling the Worker
to exit.

PR-URL: #28307
Fixes: #28299
Fixes: #28106
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. linux Issues and PRs related to the Linux platform. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flaky test-worker-debug addaleax/node
1 participant
@sam-github