Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure.py: upgrade from optparse to argparse #29813

Closed
cclauss opened this issue Oct 2, 2019 · 10 comments
Closed

configure.py: upgrade from optparse to argparse #29813

cclauss opened this issue Oct 2, 2019 · 10 comments
Labels
python PRs and issues that require attention from people who are familiar with Python.

Comments

@cclauss
Copy link
Contributor

cclauss commented Oct 2, 2019

Is your feature request related to a problem? Please describe.
Please describe the problem you are trying to solve.

Describe the solution you'd like
Please describe the desired behavior.
optparse is deprecated in favor of argparse so configure.py should be upgraded to use the newer module. This could be cherrypicked from #26725 without taking the unrelated changes in that PR.

Describe alternatives you've considered
Please describe alternative solutions or features you have considered.
Leaving the code the way it is because the current DRAFT Python 3.9 docs still show support for the deprecated module.

@cclauss cclauss added python PRs and issues that require attention from people who are familiar with Python. Hacktoberfest labels Oct 2, 2019
@vccolombo
Copy link

Hello! I would love to try this one. Already taking a look on what I can do.

@sam-github
Copy link
Contributor

Sounds reasonable to me. For the reader, argparse also exists in 2.7: https://docs.python.org/2.7/library/argparse.html

@cclauss
Copy link
Contributor Author

cclauss commented Oct 2, 2019

@vccolombo Please don't start from scratch... Start with the code in #26725

@vccolombo
Copy link

@vccolombo Please don't start from scratch... Start with the code in #26725

Hey, I opened a PR, but I could use some help there. Thank you very much

@KuthorX
Copy link
Contributor

KuthorX commented May 28, 2020

It seems this was solved, but the code didn't be merged? Should this issue be closed?

@cclauss
Copy link
Contributor Author

cclauss commented May 28, 2020

Let's leave it open. The code did not get merged so the issue remains valid.

@RaisinTen
Copy link
Contributor

Hello @cclauss. May I work on this issue please? 🙂

@cclauss
Copy link
Contributor Author

cclauss commented Oct 17, 2020

YES. You do not have to ask for permission. Your PR needs to have some tests too. If you see something that needs fixing then please open a PR. If multiple people open a PR to fix the same issue then it is almost always a learning opportunity.

@RaisinTen
Copy link
Contributor

RaisinTen commented Oct 17, 2020

@cclaus I was wondering whether I should start with the code from #26725 or #29814. The author of the second one probably added his changes to the code mentioned in the first PR but he also mentions that the PR fails in the PR description. Also, do I simply start off by copying the code and make it work or am I supposed to fetch the commits from the PR branch, add my commits and make a PR here?

@cclauss
Copy link
Contributor Author

cclauss commented Oct 17, 2020

My suggestion would be that you start a brand new PR and cherrypick things that you like from the other two. Make sure that you put closes #26725, #29813, #29814 at the top of your PR (even if they are already closed) so that reviewers can quickly find details of previous attempts. Thanks for doing this!

@Trott Trott closed this as completed in f5a86b5 Nov 12, 2020
codebytere pushed a commit that referenced this issue Nov 22, 2020
Refs: #26725
Fixes: #29813
Refs: #29814

PR-URL: #35755
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Development

No branches or pull requests

6 participants