Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createReadStream/createWithStream doesn't validate fd arg is valid #35178

Closed
ronag opened this issue Sep 13, 2020 · 4 comments · Fixed by #35187
Closed

createReadStream/createWithStream doesn't validate fd arg is valid #35178

ronag opened this issue Sep 13, 2020 · 4 comments · Fixed by #35187
Labels
fs Issues and PRs related to the fs subsystem / file system. good first issue Issues that are suitable for first-time contributors.

Comments

@ronag
Copy link
Member

ronag commented Sep 13, 2020

Missing a validateInteger check
@ronag ronag added fs Issues and PRs related to the fs subsystem / file system. good first issue Issues that are suitable for first-time contributors. labels Sep 13, 2020
@ronag
Copy link
Member Author

ronag commented Sep 13, 2020

Similar with path argument.

@dylanelliott27 dylanelliott27 mentioned this issue Sep 14, 2020
Merged
3 tasks
@dsuarezlogans
Copy link

dsuarezlogans commented Oct 1, 2020 •
edited
Loading

Hello I would like to help with this issue, but I don't completely understand what is required and where to do the work, can you please point me on the right direction please? 🙏

@abhinavjonnada82
Copy link

Can I get this with some instructions, please?

@Vboivin
Copy link
Contributor

Vboivin commented Oct 2, 2020

@dsuarezlogans @abhinavjonnada82 There is already a pull request that could potentially close this issue.
You can take a look at other good first issues for your first contribution to nodejs!

If there is a pull request attached to the issue you are looking at, I would suggest looking at another one to not conflict with the developer who is already working on it.

After finding the first issue you want to work on, you should read this document.

dylanelliott27 added a commit to dylanelliott27/node that referenced this issue Nov 10, 2020
@dylanelliott27
fs: add validation for fd and path
ab5dc94 
adds type validation to options fd & opts in createWriteStream and createReadStream.

Fixes: nodejs#35178
aduh95 pushed a commit to dylanelliott27/node that referenced this issue Mar 19, 2021
@dylanelliott27 @aduh95
fs: add validation for fd and path
ef9a3e2 
adds type validation to options fd & opts in createWriteStream and createReadStream.

Fixes: nodejs#35178
@aduh95 aduh95 closed this as completed in d4693ff Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fs: add validation for fd and path dylanelliott27/node
4 participants
@ronag @dsuarezlogans @Vboivin @abhinavjonnada82