Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N-API: npm package.json support for N-API versioning #37961

Closed
cjbj opened this issue Mar 29, 2021 · 6 comments
Closed

N-API: npm package.json support for N-API versioning #37961

cjbj opened this issue Mar 29, 2021 · 6 comments
Labels
node-api Issues and PRs related to the Node-API.

Comments

@cjbj
Copy link

cjbj commented Mar 29, 2021

Is anyone working with the npm team to add package.json syntax to restrict installing a Node.js add-on only for a given (or greater) N-API ABI version? The engines specification can be seen as a partial solution, but isn't ideal.

@legendecas legendecas added the node-api Issues and PRs related to the Node-API. label Mar 29, 2021
@mhdawson
Copy link
Member

mhdawson commented Apr 9, 2021

We've not discussed that before, so quick answer is no.

It sounded like an interesting idea to the Node-API team. Are you interested in proposing to npm?

@cjbj
Copy link
Author

cjbj commented Apr 13, 2021

@mhdawson I can open an issue. Is https:/npm/cli/issues the tracking system they are using now that https://npm.community/tags/c/bugs/cli/l/latest is closed? If you could add your weight and any useful technical information to the request, that would be helpful.

@mhdawson
Copy link
Member

I'm not sure if issues is the right place or discussions. @darcyclarke what would you suggest?

@darcyclarke
Copy link
Member

darcyclarke commented Apr 15, 2021

@cjbj this sounds like a good case for using our RFC process (ref. https:/npm/rfcs/ - or maybe create even an RRFC as an issue in that repo to test the waters/interest) - for reference, https:/npm/cli/issues has transitioned to only be intended for bugs in the npm CLI (we have other destinations for drive-by feature requests, questions etc.). In the interim of any net-new capability, engines is there - although it sounds like it's not ideal - and we will warn or throw depending on if a user defines --engines-strict

@cjbj
Copy link
Author

cjbj commented Apr 15, 2021

I've opened npm/rfcs#369

Thanks @mhdawson and @darcyclarke

@cjbj cjbj closed this as completed Apr 15, 2021
@mhdawson
Copy link
Member

@cjbj thanks, commented there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node-api Issues and PRs related to the Node-API.
Projects
None yet
Development

No branches or pull requests

4 participants