Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in lib/internal/socketaddress.js #38125

Closed
TomNes94 opened this issue Apr 7, 2021 · 1 comment
Closed

Typo in lib/internal/socketaddress.js #38125

TomNes94 opened this issue Apr 7, 2021 · 1 comment
Labels
confirmed-bug Issues with confirmed bugs.

Comments

@TomNes94
Copy link

TomNes94 commented Apr 7, 2021

  • 15
  • Irrelevant
  • Irrelevant

What steps will reproduce the bug?

The new SocketAddress class has a typo:
InternalSocketAddress.prototype.constructor = SocketAddress.prototype.construtor;

should be:
InternalSocketAddress.prototype.constructor = SocketAddress.prototype.constructor;
@Lxxyx Lxxyx added the confirmed-bug Issues with confirmed bugs. label Apr 7, 2021
@Lxxyx
Copy link
Member

Lxxyx commented Apr 7, 2021

Thanks for the feedback, would you like to submit a PR to fix it? @TomNes94

lpinca added a commit to lpinca/node that referenced this issue Apr 7, 2021
@lpinca
net: fix typo
43ee622 
`SocketAddress.prototype.construtor` -> `SocketAddress.prototype.construtor`.

Fixes: nodejs#38125
@lpinca lpinca mentioned this issue Apr 7, 2021
Closed
lpinca added a commit to lpinca/node that referenced this issue Apr 7, 2021
@lpinca
net: fix typo
7f7f135 
`SocketAddress.prototype.construtor` -> `SocketAddress.prototype.constructor`.

Fixes: nodejs#38125
@aduh95 aduh95 closed this as completed in 7869761 Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed-bug Issues with confirmed bugs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

net: fix typo lpinca/node
2 participants
@Lxxyx @TomNes94