Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Make configure forwards compatible by putting parenties with prints #4462

Closed
ghost opened this issue Dec 29, 2015 · 4 comments
Closed
Labels
build Issues and PRs related to build files or the CI. feature request Issues that request new features to be added to Node.js.

Comments

@ghost
Copy link

ghost commented Dec 29, 2015

Nodejs can not build with python3 currently because print statements use a python 2 idiom.

It has been pointed out before that node will not build with python3 because of its dependence on gyp which has similar problems but in the mean time we can add a few parenthesis and be more prepared for when compatibility is possible.

So my request is that we make the code more forwards compatible.

@mscdex mscdex added build Issues and PRs related to build files or the CI. feature request Issues that request new features to be added to Node.js. labels Dec 29, 2015
@Fishrock123
Copy link
Contributor

and be more prepared for when compatibility is possible.

I don't believe gyp is making any guarantee of this. cc.... @bnoordhuis?

@bnoordhuis
Copy link
Member

gyp is still python2 so making the configure script python3-compatible is only a very modest win.

@ghost
Copy link
Author

ghost commented Jan 11, 2016

But a modest win indeed. I got it done pretty easily. A sed guru could do it in 20 seconds but I just used vim. :map z elr(A) return /print. Then you can press n and press z if it needs parenthesis otherwise press n again.

I made quick work of it and found that gyp was an issue afterword. I didn't send in a pull request because I figured you would care about formatting and I didn't have 100% consistency as I changed my method half way through so I thought I would say something first.

Modest benefits and interdependent programs are exactly why we are still on python 2. It's just a matter of a few parenthesis whose placement can be nearly automated over one file.

If you would like a pull request let me know.

@bnoordhuis
Copy link
Member

#9657 fixed this after a fashion so I'll go ahead and close this out. Thanks for the suggestion and the offer of a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. feature request Issues that request new features to be added to Node.js.
Projects
None yet
Development

No branches or pull requests

3 participants