-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request: Make configure forwards compatible by putting parenties with prints #4462
Comments
I don't believe |
gyp is still python2 so making the configure script python3-compatible is only a very modest win. |
But a modest win indeed. I got it done pretty easily. A sed guru could do it in 20 seconds but I just used vim. :map z elr(A) return /print. Then you can press n and press z if it needs parenthesis otherwise press n again. I made quick work of it and found that gyp was an issue afterword. I didn't send in a pull request because I figured you would care about formatting and I didn't have 100% consistency as I changed my method half way through so I thought I would say something first. Modest benefits and interdependent programs are exactly why we are still on python 2. It's just a matter of a few parenthesis whose placement can be nearly automated over one file. If you would like a pull request let me know. |
#9657 fixed this after a fashion so I'll go ahead and close this out. Thanks for the suggestion and the offer of a pull request. |
Nodejs can not build with python3 currently because print statements use a python 2 idiom.
It has been pointed out before that node will not build with python3 because of its dependence on gyp which has similar problems but in the mean time we can add a few parenthesis and be more prepared for when compatibility is possible.
So my request is that we make the code more forwards compatible.
The text was updated successfully, but these errors were encountered: