Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--watch mode shouldn't enter REPL, causes a crash #45006

Closed
panva opened this issue Oct 14, 2022 · 2 comments · Fixed by #45058
Closed

--watch mode shouldn't enter REPL, causes a crash #45006

panva opened this issue Oct 14, 2022 · 2 comments · Fixed by #45058
Labels
watch-mode Issues and PRs related to watch mode

Comments

@panva
Copy link
Member

panva commented Oct 14, 2022

Version

v18.11.0

Platform

Darwin M1-MacBook-Pro.local 21.6.0 Darwin Kernel Version 21.6.0: Mon Aug 22 20:19:52 PDT 2022; root:xnu-8020.140.49~2/RELEASE_ARM64_T6000 arm64

Subsystem

No response

What steps will reproduce the bug?

Kapture 2022-10-14 at 20 32 08

How often does it reproduce? Is there a required condition?

always

What is the expected behavior?

--watch alone shouldn't enter a REPL

What do you see instead?

REPL is started, any input crashes the process

Additional information

No response

@panva
Copy link
Member Author

panva commented Oct 14, 2022

➜  node --watch --trace-uncaught
Welcome to Node.js v18.11.0.
Type ".help" for more information.
> f
node:internal/readline/emitKeypressEvents:74
            throw err;
            ^
This Environment was initialized without a V8::Inspector
Thrown at:
    at onData (node:internal/readline/emitKeypressEvents:74:13)
    at emit (node:events:513:28)
    at emit (node:domain:489:12)
    at addChunk (node:internal/streams/readable:324:12)
    at readableAddChunk (node:internal/streams/readable:297:9)
    at Readable.push (node:internal/streams/readable:234:10)
    at onStreamRead (node:internal/stream_base_commons:190:23)
    at callbackTrampoline (node:internal/async_hooks:130:17)

@panva
Copy link
Member Author

panva commented Oct 14, 2022

cc @MoLow

@MoLow MoLow added the watch-mode Issues and PRs related to watch mode label Oct 18, 2022
nodejs-github-bot pushed a commit that referenced this issue Oct 20, 2022
PR-URL: #45058
Fixes: #45006
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
RafaelGSS pushed a commit that referenced this issue Nov 1, 2022
PR-URL: #45058
Fixes: #45006
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
RafaelGSS pushed a commit that referenced this issue Nov 10, 2022
PR-URL: #45058
Fixes: #45006
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams pushed a commit that referenced this issue Dec 30, 2022
PR-URL: #45058
Fixes: #45006
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams pushed a commit that referenced this issue Dec 30, 2022
PR-URL: #45058
Fixes: #45006
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams pushed a commit that referenced this issue Jan 3, 2023
PR-URL: #45058
Fixes: #45006
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
watch-mode Issues and PRs related to watch mode
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants