url: move originFor, domainToAscii and domainToUnicode #10512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
italoacasas
approved these changes
Dec 29, 2016
|
|
|
Yeah, returning the non-serialized version is precisely the point. Still, I consider it to still be speculative as a public API. |
targos
approved these changes
Dec 29, 2016
jasnell
force-pushed
the
url-updates2
branch
from
c4a7ab9
to
5acce63
Compare
|
Rebased and updated |
|
Failures in freebsd are unrelated |
targos
approved these changes
Dec 30, 2016
|
Cleaned up some stale processes on a FreeBSD host in CI. Let's try FreeBSD CI again: https://ci.nodejs.org/job/node-test-commit-freebsd/6141/ |
Move non-standard methods to `url` module instead of exposing as static methods on the `URL` object.
jasnell
force-pushed
the
url-updates2
branch
from
5acce63
to
734b914
Compare
jasnell
added a commit
that referenced
this pull request
Dec 30, 2016
Move non-standard methods to `url` module instead of exposing as static methods on the `URL` object. PR-URL: #10512 Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
|
Landed in abc1633 |
evanlucas
pushed a commit
that referenced
this pull request
Jan 3, 2017
Move non-standard methods to `url` module instead of exposing as static methods on the `URL` object. PR-URL: #10512 Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
Move non-standard methods to `url` module instead of exposing as static methods on the `URL` object. PR-URL: #10512 Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
joyeecheung
added
the
whatwg-url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
url
Description of change
Move non-standard methods from the new experimental
URLimplementationto
urlmodule instead of exposing as static methods on theURLobject.