Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify the statement in vm.createContext() API #10519

Closed
wants to merge 1 commit into from

Conversation

AnnaMag
Copy link
Member

@AnnaMag AnnaMag commented Dec 29, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Clarifying the statement in vm.createContext([]) of
https://nodejs.org/api/vm.html
Outside of scripts run by the vm module, sandbox will remain unchanged.

Sandbox does reflect the changes made within the vm module.
What remains unchanged are the global variables.
To avoid confusion, the statement could benefit from a re-write,
possibly with a code snippet to illustrate the point.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. lts-watch-v6.x labels Dec 29, 2016
@AnnaMag
Copy link
Member Author

AnnaMag commented Dec 29, 2016

@fhinkel

fhinkel pushed a commit to fhinkel/node that referenced this pull request Jan 4, 2017
PR-URL: nodejs#10519
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Prince John Wesley <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@fhinkel
Copy link
Member

fhinkel commented Jan 4, 2017

Landed in c57caf5. Thanks!

@fhinkel fhinkel closed this Jan 4, 2017
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
PR-URL: #10519
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Prince John Wesley <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@MylesBorins
Copy link
Contributor

@fhinkel does this apply to v4.x or v6.x?

@fhinkel
Copy link
Member

fhinkel commented Jan 23, 2017

Both.

@AnnaMag AnnaMag deleted the doc-vm-createContext branch January 25, 2017 11:03
MylesBorins pushed a commit that referenced this pull request Mar 7, 2017
PR-URL: #10519
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Prince John Wesley <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
PR-URL: #10519
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Prince John Wesley <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants