Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add non-internet resolveAny tests #13883

Closed
wants to merge 2 commits into from

Commits on Jul 15, 2017

  1. deps: cherry-pick 18ea996 from c-ares upstream

    Original commit message:
    
        ares_parse_naptr_reply: make buffer length check more accurate
    
        9478908a490a6bf009ba58d81de8c1d06d50a117 introduced a length check
        for records parsed by `ares_parse_naptr_reply()`. However, that
        function is designed to parse replies which also contain non-NAPTR
        records; for A records, the `rr_len > 7` check will fail as there
        are only 4 bytes of payload.
        In particular, parsing ANY replies for NAPTR records was broken
        by that patch.
    
        Fix that by moving the check into the case in which it is already
        known that the record is a NAPTR record.
    
    Ref: c-ares/c-ares@18ea996
    addaleax committed Jul 15, 2017
    Configuration menu
    Copy the full SHA
    185b5d5 View commit details
    Browse the repository at this point in the history
  2. test: add non-internet resolveAny tests

    This is a bit of a check to see how people feel about having this kind
    of test.
    
    Ref: nodejs#13137
    PR-URL: nodejs#13883
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    addaleax committed Jul 15, 2017
    Configuration menu
    Copy the full SHA
    9c1e270 View commit details
    Browse the repository at this point in the history