c-ares NAPTR parser out of bounds access #13897
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
cares
|
when will cares release the new version? how about updating to 1.13 directly? |
Maybe in master/v8.x, but is it really an option for v6.x and v4.x? |
|
I didn't see any backwards compatibility concerns in the 1.12..1.13 diff. I'm good with upgrading wholesale in all release branches. |
|
Consider this just an issue then. |
|
This has landed in all active release lines |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CVE: CVE-2017-1000381
Upstream bug: https://c-ares.haxx.se/adv_20170620.html
Upstream patch: https://c-ares.haxx.se/CVE-2017-1000381.patch
I haven't seen PR/issue for this CVE, so I created one. It's the same as upstream c-ares patch.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
bundled c-ares