Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade npm to 2.8.4 #1515

Closed
wants to merge 3 commits into from
Closed

deps: upgrade npm to 2.8.4 #1515

wants to merge 3 commits into from

Conversation

othiym23
Copy link
Contributor

This PR is branched from master, not v1.x, in keeping with @Fishrock123's feedback.

This is a fairly small release, and you can refer to the release notes for details. The most significant fix is the improvement in error-handling in node-tar, although new users will also appreciate the tweaks that make npm init more pleasant to use.

r: @Fishrock123
r: @chrisdickinson

othiym23 and others added 3 commits April 23, 2015 23:09
Every npm version bump requires a few patches to be floated on
node-gyp for io.js compatibility. These patches are found in
03d1992,
5de334c, and
da730c7. This commit squashes
them into a single commit.

PR-URL: nodejs#990
Reviewed-By: Ben Noordhuis <[email protected]>
On Windows, when node or io.js attempts to dynamically load a compiled
addon, the compiled addon tries to load node.exe or iojs.exe again -
depending on which import library the module used when it was linked.
This causes many compiled addons to break when node.exe or iojs.exe are
renamed, because when the binary has been renamed the addon DLL can't
find the (right) .exe file to load its imports from.

This patch gives compiled addon developers an option to overcome this
restriction by compiling a delay-load hook into their binary. The
delay-load hook ensures that whenever a module tries to load imports
from node.exe/iojs.exe, it'll just look at the process image, thereby
making the addon work regardless of what name the node/iojs binary has.

To enable this feature, the addon developer must set the
'win_delay_load_hook' option to 'true' in their binding.gyp file, like
this:

```
{
  'targets': [
    {
      'target_name': 'ernie',
      'win_delay_load_hook': 'true',
      ...
```

Bug: nodejs#751
Bug: nodejs#965
Upstream PR: nodejs/node-gyp#599

PR-URL: nodejs#1251
Reviewed-By: Rod Vagg <[email protected]>

PR-URL: nodejs#1266
Reviewed-By: Ben Noordhuis <[email protected]>
@othiym23 othiym23 added the npm Issues and PRs related to the npm client dependency or the npm registry. label Apr 24, 2015
@@ -0,0 +1,233 @@
# qs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be causing problems for me locally – I have README.md on disk, so git am fails on this patch. I'll look into this more tomorrow morning! @Fishrock123 mind taking a look to see if you're having trouble with this file as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some weird problems with this exact file recently trying to change my main working branch from v1.x to master and it wasn't to do with this patch, I didn't end up working it out but had to do some hackery to make git happy with the switch. Odd.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no not again >_<

Yeah, this patch is also broken...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... after last week's goat rodeo, I reviewed my git settings, and I'm not actually doing anything special with case sensitivity when creating the patch. It's probably something to do with removing deps/npm completely before unpacking the new version, but that's important to do to catch all of the deletions. I'll investigate and see what I can come up with. I don't think that creating the patch on a case-sensitive filesystem is going to help when applying the patch on a case-insensitive filesystem.

@Fishrock123
Copy link
Contributor

LGTM minus the whole patch-is-broken thing...

@Fishrock123
Copy link
Contributor

Replaced by #1573

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants