Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: support generic Duplex streams #16267

Closed
wants to merge 2 commits into from
Closed

http: support generic Duplex streams #16267

wants to merge 2 commits into from

Commits on Oct 22, 2017

  1. test: add makeDuplexPair() helper 

    Add a utility for adding simple, streams-API based duplex pairs.

PR-URL: nodejs#16269
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @addaleax
    addaleax committed Oct 22, 2017
    Configuration menu
    Copy the full SHA
    f54889a View commit details
    Browse the repository at this point in the history

  2. http: support generic Duplex streams 

    Support generic `Duplex` streams through more duck typing
on the server and client sides.

Since HTTP is, as a protocol, independent of its underlying transport
layer, Node.js should not enforce any restrictions on what streams
its HTTP parser may use.

Ref: nodejs#16256
PR-URL: nodejs#16267
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
    @addaleax
    addaleax committed Oct 22, 2017
    Configuration menu
    Copy the full SHA
    e5a0fdd View commit details
    Browse the repository at this point in the history