Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspector: no async tracking for promises #17118

Closed
wants to merge 2 commits into from
Closed

inspector: no async tracking for promises #17118

wants to merge 2 commits into from

Commits on Nov 18, 2017

  1. inspector: no async tracking for promises 

    `Promise` instances are already tracked by V8 itself.
This fixes `sequential/test-inspector-async-stack-traces-promise-then`
in debug mode (it previously crashed because our tracking
and the V8 tracking were not properly nested).

Ref: https://chromium-review.googlesource.com/c/v8/v8/+/707058
Fixes: nodejs#17017
    @addaleax
    addaleax committed Nov 18, 2017
    Configuration menu
    Copy the full SHA
    0fb6f70 View commit details
    Browse the repository at this point in the history

  2. [squash] rename promises → promiseIds

    @addaleax
    addaleax committed Nov 18, 2017
    Configuration menu
    Copy the full SHA
    d6a5991 View commit details
    Browse the repository at this point in the history