Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix test-v8 target #17269

Closed
wants to merge 1 commit into from
Closed

build: fix test-v8 target #17269

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Nov 23, 2017

Clean the deps/v8 directory before rebuilding node for the hash seed
test. It is necessary to avoid the script added in 1 to use ignored
files while generating node-debug-support.cc.

Fixes: nodejs/node-v8#26

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

/cc @bnoordhuis @mmarchini

Clean the deps/v8 directory before rebuilding node for the hash seed
test. It is necessary to avoid the script added in [1] to use ignored
files while generating `node-debug-support.cc`.

[1]: nodejs#14901

Fixes: nodejs/node-v8#26
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Nov 23, 2017
@targos targos added the v8 engine Issues and PRs related to the V8 dependency. label Nov 23, 2017
@targos targos mentioned this pull request Nov 23, 2017
2 tasks
@targos
Copy link
Member Author

targos commented Nov 23, 2017

I already tested this on my v8-6.3 branch: https://ci.nodejs.org/job/node-test-commit-v8-linux/1071/
CI run for this PR: https://ci.nodejs.org/job/node-test-commit-v8-linux/1072/

@@ -501,6 +501,7 @@ test-v8: v8
--no-presubmit \
--shell-dir=$(PWD)/deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) \
$(TAP_V8)
git clean -fdxq -- deps/v8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we assume the presence of git, i.e. is this target valid for running from the source tarball?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This target depends on the v8 target, which executes make-v8.sh, which already assumes the presence of git.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But maybe replace x with X?
If I'm understanding git's logic, it'll use node's .git not deps/v8/.git

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deps/v8/.git is removed in make-v8.sh during cleanup:

find v8 -name ".git" | xargs rm -rf || true

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So definatly -X (it will remove explicitly ignored files, while keeping newly added files)

@targos
Copy link
Member Author

targos commented Nov 23, 2017

Test failure is unrelated. See #17270

@bnoordhuis
Copy link
Member

I want to propose reverting #14901 for now. tools/gen-postmortem-metadata.py needs some more work, IMO. I'll open a PR.

@refack
Copy link
Contributor

refack commented Nov 23, 2017

I see no harm in this change even after 088bba3.
AFAICT make test-hash-seed rebuilds V8 anyway, so there should be no performance lost.

@MylesBorins
Copy link
Contributor

landed in 6c47033

MylesBorins pushed a commit that referenced this pull request Nov 29, 2017
Clean the deps/v8 directory before rebuilding node for the hash seed
test. It is necessary to avoid the script added in [1] to use ignored
files while generating `node-debug-support.cc`.

[1]: #14901

PR-URL: #17269
Fixes: nodejs/node-v8#26
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
Clean the deps/v8 directory before rebuilding node for the hash seed
test. It is necessary to avoid the script added in [1] to use ignored
files while generating `node-debug-support.cc`.

[1]: #14901

PR-URL: #17269
Fixes: nodejs/node-v8#26
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
Clean the deps/v8 directory before rebuilding node for the hash seed
test. It is necessary to avoid the script added in [1] to use ignored
files while generating `node-debug-support.cc`.

[1]: #14901

PR-URL: #17269
Fixes: nodejs/node-v8#26
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
Clean the deps/v8 directory before rebuilding node for the hash seed
test. It is necessary to avoid the script added in [1] to use ignored
files while generating `node-debug-support.cc`.

[1]: #14901

PR-URL: #17269
Fixes: nodejs/node-v8#26
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
Clean the deps/v8 directory before rebuilding node for the hash seed
test. It is necessary to avoid the script added in [1] to use ignored
files while generating `node-debug-support.cc`.

[1]: #14901

PR-URL: #17269
Fixes: nodejs/node-v8#26
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
Clean the deps/v8 directory before rebuilding node for the hash seed
test. It is necessary to avoid the script added in [1] to use ignored
files while generating `node-debug-support.cc`.

[1]: #14901

PR-URL: #17269
Fixes: nodejs/node-v8#26
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
@targos targos deleted the fix-v8-test branch October 17, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants