Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: eslint rule for assert.throws -> common.expectsError #17557

Closed
wants to merge 2 commits into from
Closed

tools: eslint rule for assert.throws -> common.expectsError #17557

wants to merge 2 commits into from

Commits on Dec 9, 2017

  1. test: use common.expectsError

    @apapirovski
    apapirovski committed Dec 9, 2017
    Configuration menu
    Copy the full SHA
    9d11b02 View commit details
    Browse the repository at this point in the history

  2. tools: prefer common.expectsError in tests 

    Add lint rule to validate that common.expectsError is being used
instead of assert.throws(fn, common.expectsError(err));
    @apapirovski
    apapirovski committed Dec 9, 2017
    Configuration menu
    Copy the full SHA
    a8e3c37 View commit details
    Browse the repository at this point in the history