Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove redundant JSStream::DoAfterWrite #17713

Closed
wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Finish<WriteWrap> already does the same thing and is called immediately afterwards anyway.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src/js_stream

`Finish<WriteWrap>` already does the same thing and is
called immediately afterwards anyway.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Dec 16, 2017
@addaleax addaleax added the lib / src Issues and PRs related to general changes in the lib or src directory. label Dec 16, 2017
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@addaleax
Copy link
Member Author

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 17, 2017
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 21, 2017
@addaleax
Copy link
Member Author

addaleax commented Dec 21, 2017

Landed in 901e9a1  

@addaleax addaleax closed this Dec 21, 2017
@addaleax addaleax deleted the no-do-after-write branch December 21, 2017 19:56
addaleax added a commit that referenced this pull request Dec 21, 2017
`Finish<WriteWrap>` already does the same thing and is
called immediately afterwards anyway.

PR-URL: #17713
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
`Finish<WriteWrap>` already does the same thing and is
called immediately afterwards anyway.

PR-URL: #17713
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
`Finish<WriteWrap>` already does the same thing and is
called immediately afterwards anyway.

PR-URL: #17713
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
`Finish<WriteWrap>` already does the same thing and is
called immediately afterwards anyway.

PR-URL: #17713
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
@gibfahn
Copy link
Member

gibfahn commented Jan 24, 2018

Should this go back to 6.x or 8.x? If so please raise a backport PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants