Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x] test: remove orphaned entries from status #19043

Closed
wants to merge 3 commits into from
Closed

[v8.x] test: remove orphaned entries from status #19043

wants to merge 3 commits into from

Commits on Mar 20, 2018

  1. benchmark: fix punycode test for --without-intl 

    PR-URL: nodejs#16251
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @TimothyGu @MylesBorins
    TimothyGu authored and MylesBorins committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    db77e13 View commit details
    Browse the repository at this point in the history

  2. fs: fix createReadStream(…, {end: n}) for non-seekable fds 

    82bdf8f fixed an issue by silently modifying the `start`
option for the case when only `end` is passed, in order to perform
reads from a specified range in the file.

However, that approach does not work for non-seekable files, since
a numeric `start` option means that positioned reads will be used
to read data from the file.

This patch fixes that, and instead ends reading after a specified
size by adjusting the read buffer size.

This way we avoid re-introducing the bug that 82bdf8f fixed,
and align behaviour with the native file stream mechanism
introduced in nodejs#18936 as well.

Backport-PR-URL: nodejs#19410
PR-URL: nodejs#19329
Fixes: nodejs#19240
Refs: nodejs#18121
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chen Gang <[email protected]>
    @addaleax @MylesBorins
    addaleax authored and MylesBorins committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    5586089 View commit details
    Browse the repository at this point in the history

  3. test: remove orphaned entries from status

    @kfarnung
    kfarnung committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    ae25862 View commit details
    Browse the repository at this point in the history