Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x backport] build: make linters independent of local node #19190

Closed
wants to merge 2 commits into from
Closed

[v8.x backport] build: make linters independent of local node #19190

wants to merge 2 commits into from

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Mar 6, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Refs: #18272

@joyeecheung
build: make lint-md independent of local node
126aefb 
PR-URL: nodejs#18272
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@joyeecheung
build: make lint-js independent of local node
4526a07 
PR-URL: nodejs#18272
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v8.x labels Mar 6, 2018
@joyeecheung
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/13557/

@MylesBorins
Copy link
Contributor

one more ci: https://ci.nodejs.org/job/node-test-pull-request/13785/

@gibfahn gibfahn self-assigned this Mar 26, 2018
@BethGriggs
Copy link
Member

CI 3: https://ci.nodejs.org/job/node-test-commit/17202/

@MylesBorins MylesBorins force-pushed the v8.x-staging branch 2 times, most recently from 44cb0d3 to 16bf5fe Compare March 30, 2018 03:28
@joyeecheung
Copy link
Member Author

CI failures appear to be unrelated

@gibfahn
Copy link
Member

gibfahn commented Apr 3, 2018

New CI to see what's going on here: https://ci.nodejs.org/job/node-test-commit/17394/

BethGriggs pushed a commit that referenced this pull request Apr 10, 2018
@joyeecheung @BethGriggs
build: make lint-md independent of local node
d537f45 
PR-URL: #18272
Backport-PR-URL: #19190
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 10, 2018
@joyeecheung @BethGriggs
build: make lint-js independent of local node
333d7dd 
PR-URL: #18272
Backport-PR-URL: #19190
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs
Copy link
Member

Landed in 016a28a...333d7dd.

@BethGriggs BethGriggs closed this Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees

@gibfahn gibfahn

Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joyeecheung @MylesBorins @BethGriggs @gibfahn @nodejs-github-bot