Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Revert "fs: fix options.end of fs.ReadStream()" #19328

Closed
wants to merge 1 commit into from
Closed

[8.x] Revert "fs: fix options.end of fs.ReadStream()" #19328

wants to merge 1 commit into from

Commits on Mar 13, 2018

  1. Revert "fs: fix options.end of fs.ReadStream()" 

    This reverts commit b343cb6.

Some people were relying on the behavior of this.start being able to be
undefined, whereas after the change it is being set to 0.

Refs: nodejs#19240
Refs: nodejs#18121
    @MylesBorins
    MylesBorins committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    ec8ff67 View commit details
    Browse the repository at this point in the history