Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: setEncoding error for incoming socket connections #19344

Closed
wants to merge 9 commits into from

Commits on Apr 3, 2018

  1. http: setEncoding override for incoming packets

    added override to socket.setEncoding to not allow encoding changes for
    incoming HTTP requests
    added tests to ensure method throws JavaScript error
    because an HTTP buffer must be in US-ASCII, this function should not
    be allowed and should throw an Error
    currently, the process encounters a fatal v8 error and crashes
    
    error report detailed in
    [issue nodejs#18118](nodejs#18118)
    
    Fixes: nodejs#18118
    Ref: nodejs#18178
    iSkore committed Apr 3, 2018
    Configuration menu
    Copy the full SHA
    a7e2aab View commit details
    Browse the repository at this point in the history
  2. test: added tests for setEncoding error check

    added test to ensure setEncoding inside socket connection
    would throw an error
    
    Fixes: nodejs#18118
    Ref: nodejs#18178
    iSkore committed Apr 3, 2018
    Configuration menu
    Copy the full SHA
    345ff3c View commit details
    Browse the repository at this point in the history
  3. docs, errors, http: disallow setEncoding on incoming packets

    added ERR_HTTP_INCOMING_SOCKET_ENCODING error and error docs
    throw ERR_HTTP_INCOMING_SOCKET_ENCODING error when incoming request
    socket encoding is manipulated
    
    error report detailed in nodejs#18118
    
    Fixes: nodejs#18118
    Ref: nodejs#18178
    iSkore committed Apr 3, 2018
    Configuration menu
    Copy the full SHA
    4643c63 View commit details
    Browse the repository at this point in the history
  4. docs, errors: note RFC compliance in error message and documentation

    added note and link to RFC7230
    
    >A recipient MUST parse an HTTP message as a sequence of octets in an
    encoding that is a superset of US-ASCII [USASCII].
    
    Ref: https://tools.ietf.org/html/rfc7230#section-3
    
    Ref: nodejs#18118
    Ref: nodejs#18178
    Ref: nodejs#19344
    iSkore committed Apr 3, 2018
    Configuration menu
    Copy the full SHA
    f3c429c View commit details
    Browse the repository at this point in the history
  5. tests, http: fixed call to ERR_HTTP_INCOMING_SOCKET_ENCODING

    internal/errors declaration updated to match new scheme
    
    PR-URL: nodejs#19344
    
    Ref: https://tools.ietf.org/html/rfc7230#section-3
    
    Ref: nodejs#18118
    Ref: nodejs#18178
    Ref: nodejs#19344
    iSkore committed Apr 3, 2018
    Configuration menu
    Copy the full SHA
    3613e8d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    190ef7e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    06a34eb View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2018

  1. http: minor change per review request

    PR-URL: nodejs#19344
    iSkore committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    cd2c3ce View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2018

  1. Configuration menu
    Copy the full SHA
    a8c605e View commit details
    Browse the repository at this point in the history