[v8.x backport] test: move tmpdir to submodule of common #19488
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move tmpdir functionality to its own module (common/tmpdir). PR-URL: nodejs#17856 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
nodejs-github-bot
added
addons
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2018
Move tmpdir functionality to its own module (common/tmpdir). Backport-PR-URL: #19488 PR-URL: #17856 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
|
landed in f91064f |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 28, 2018
Move tmpdir functionality to its own module (common/tmpdir). Backport-PR-URL: #19488 PR-URL: #17856 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 30, 2018
Move tmpdir functionality to its own module (common/tmpdir). Backport-PR-URL: #19488 PR-URL: #17856 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move tmpdir functionality to its own module (common/tmpdir).
PR-URL: #17856
Reviewed-By: James M Snell [email protected]
Reviewed-By: Gibson Fahnestock [email protected]
Reviewed-By: Ruben Bridgewater [email protected]
Reviewed-By: Joyee Cheung [email protected]
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes