Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update link according to NIST bibliography #19593

Closed

Conversation

tniessen
Copy link
Member

According to Appendix E of NIST SP 800 38D, this is the document the link orginally pointed to.

Fixes: #17619

Checklist

According to NIST SP 800 38D, this is the document the link orginally
pointed to.

Fixes: nodejs#17619
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 25, 2018
@tniessen tniessen added the crypto Issues and PRs related to the crypto subsystem. label Mar 25, 2018
Copy link
Contributor

@starkwang starkwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a new available link for this?

@tniessen
Copy link
Member Author

@starkwang There is no "official" link anymore, NIST does not seem to provide the document anymore. IMO it is sufficient to provide the name of the document and the authors.

// http://csrc.nist.gov/groups/ST/toolkit/BCM/documents/
// proposedmodes/gcm/gcm-revised-spec.pdf
// Following test cases are from "The Galois/Counter Mode of Operation (GCM)"
// by D. McGrew and J. Viega, published by the Natl. Inst. Stand. Technol.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

National Institute of Standards and Technology?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah... Natl. Inst. Stand. Technol. is the abbreviation which is used in their own document, I just copied it. Personally, I would just write NIST, what do you prefer?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIST LGTM.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think NIST would be better.

@tniessen
Copy link
Member Author

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 27, 2018
@trivikr
Copy link
Member

trivikr commented Mar 27, 2018

Landed in ed0501f

@trivikr trivikr closed this Mar 27, 2018
trivikr pushed a commit that referenced this pull request Mar 27, 2018
According to NIST SP 800 38D, this is the document the link orginally
pointed to.

Fixes: #17619

PR-URL: #19593
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
targos pushed a commit that referenced this pull request Apr 2, 2018
According to NIST SP 800 38D, this is the document the link orginally
pointed to.

Fixes: #17619

PR-URL: #19593
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@targos targos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 4, 2018
@targos targos mentioned this pull request Apr 4, 2018
BethGriggs pushed a commit that referenced this pull request Dec 4, 2018
According to NIST SP 800 38D, this is the document the link orginally
pointed to.

Fixes: #17619

PR-URL: #19593
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated link in test-crypto-authenticated
10 participants