Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: remove waitTrailers listener after closing a stream #21764

Closed
wants to merge 3 commits into from
Closed

http2: remove waitTrailers listener after closing a stream #21764

wants to merge 3 commits into from

Commits on Jul 11, 2018

  1. http2: remove waitTrailers listener after closing a stream

    When `writeHear` of `Http2ServerResponse` instance are called with 204,
    205 and 304 status codes an underlying stream closes.
    If call `end` method after sending any of these status codes it will
    cause an error `TypeError: Cannot read property 'Symbol(trailers)' of
    undefined` because a reference to `Http2ServerResponse` instance
    associated with Http2Stream already was deleted.
    The closing of stream causes emitting `watiTrailers` event and, when
    this event handles inside `onStreamTrailerReady`  handler, there is
    no reference to Http2ServerResponse instance.
    
    Fises: #21740
    RidgeA committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    5222ec2 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2018

  1. Configuration menu
    Copy the full SHA
    0e914d5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    74389f2 View commit details
    Browse the repository at this point in the history