Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update ESLint to 5.3.0 #22134

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 5, 2018

Since we made some efforts to make the ESLint updates in Node.js core a little bit less churn-y, maybe we can do more frequent smaller updates like this? (Or maybe it's still too churn-y?)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Aug 5, 2018
@Trott
Copy link
Member Author

Trott commented Aug 5, 2018

Since the lite CI runs the linter and none of the other jobs in node-test-pull-request touch this code, the lite CI is probably sufficient here.

@Trott
Copy link
Member Author

Trott commented Aug 5, 2018

@Trott
Copy link
Member Author

Trott commented Aug 5, 2018

@nodejs/linting

Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Copy link
Contributor

@maclover7 maclover7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Trott
Copy link
Member Author

Trott commented Aug 8, 2018

Landed in 6ad12d4

Trott added a commit to Trott/io.js that referenced this pull request Aug 8, 2018
PR-URL: nodejs#22134
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@Trott Trott closed this Aug 8, 2018
targos pushed a commit that referenced this pull request Aug 11, 2018
PR-URL: #22134
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@Trott Trott deleted the eslint-5.3.0 branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants