Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add loader path to rpath for cctest #23168

Closed
wants to merge 1 commit into from

Conversation

rubys
Copy link
Member

@rubys rubys commented Sep 29, 2018

Building on Mac OS/X as follows:

./configure --shared
make -j4 test

Results in:

dyld: Library not loaded: @rpath/libnode.67.dylib
  Referenced from: /Users/rubys/git/node-shared/out/Release/cctest
  Reason: image not found
make: *** [cctest] Abort trap: 6

This change adds the loader path to the runtime path for the cctest executable.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Building on Mac OS/X as follows:

```
./configure --shared
make -j4 test
```

Results in:

```
dyld: Library not loaded: @rpath/libnode.67.dylib
  Referenced from: /Users/rubys/git/node-shared/out/Release/cctest
  Reason: image not found
make: *** [cctest] Abort trap: 6
```

This change adds the loader path to the runtime path for the `cctest` executable.
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Sep 29, 2018
@rubys
Copy link
Member Author

rubys commented Sep 29, 2018

@rubys
Copy link
Member Author

rubys commented Sep 29, 2018

node-test-commit-windows-fanned failure on sequential/test-gc-http-client-connaborted matches nodejs/reliability#17

@addaleax
Copy link
Member

/cc @nodejs/platform-macos

@rubys
Copy link
Member Author

rubys commented Sep 30, 2018

@rubys
Copy link
Member Author

rubys commented Sep 30, 2018

Restart node test commit: https://ci.nodejs.org/job/node-test-commit/21891/

@rubys
Copy link
Member Author

rubys commented Oct 1, 2018

Sigh* Each run has a different set of transient errors.

New CI: https://ci.nodejs.org/job/node-test-pull-request/17549/

@mcollina
Copy link
Member

mcollina commented Oct 1, 2018

@rubys
Copy link
Member Author

rubys commented Oct 1, 2018

@mhdawson
Copy link
Member

mhdawson commented Oct 1, 2018

@yhwang can you take a look?

@rubys
Copy link
Member Author

rubys commented Oct 1, 2018

@rubys
Copy link
Member Author

rubys commented Oct 1, 2018

cc @nodejs/build I'm looking for advice here. I'm adding an option that only applies to shared library builds on Mac OS/X. None of the CI tests are for shared library builds. Despite this, every time I run, I see an intermittent failure (e.g. timeout) on either Linux or Windows.

@refack
Copy link
Contributor

refack commented Oct 1, 2018

Am I wrong, but https://ci.nodejs.org/job/node-test-pull-request/17564/ seems to be green.
It spawned https://ci.nodejs.org/job/node-test-commit/21944/
Which is newer then the one linked in the github report https://ci.nodejs.org/job/node-test-commit/21942/
So this passed CI ✔️

@danbev
Copy link
Contributor

danbev commented Oct 4, 2018

Landed in 6696354.

@danbev danbev closed this Oct 4, 2018
danbev pushed a commit that referenced this pull request Oct 4, 2018
Building on Mac OS/X as follows:

```
./configure --shared
make -j4 test
```

Results in:

```
dyld: Library not loaded: @rpath/libnode.67.dylib
  Referenced from: /Users/rubys/git/node-shared/out/Release/cctest
  Reason: image not found
make: *** [cctest] Abort trap: 6
```

This change adds the loader path to the runtime path for the `cctest` executable.

PR-URL: #23168
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Oct 5, 2018
Building on Mac OS/X as follows:

```
./configure --shared
make -j4 test
```

Results in:

```
dyld: Library not loaded: @rpath/libnode.67.dylib
  Referenced from: /Users/rubys/git/node-shared/out/Release/cctest
  Reason: image not found
make: *** [cctest] Abort trap: 6
```

This change adds the loader path to the runtime path for the `cctest` executable.

PR-URL: #23168
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
Building on Mac OS/X as follows:

```
./configure --shared
make -j4 test
```

Results in:

```
dyld: Library not loaded: @rpath/libnode.67.dylib
  Referenced from: /Users/rubys/git/node-shared/out/Release/cctest
  Reason: image not found
make: *** [cctest] Abort trap: 6
```

This change adds the loader path to the runtime path for the `cctest` executable.

PR-URL: #23168
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit to BethGriggs/node that referenced this pull request Mar 20, 2019
Building on Mac OS/X as follows:

```
./configure --shared
make -j4 test
```

Results in:

```
dyld: Library not loaded: @rpath/libnode.67.dylib
  Referenced from: /Users/rubys/git/node-shared/out/Release/cctest
  Reason: image not found
make: *** [cctest] Abort trap: 6
```

This change adds the loader path to the runtime path for the `cctest` executable.

PR-URL: nodejs#23168
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Mar 20, 2019
Building on Mac OS/X as follows:

```
./configure --shared
make -j4 test
```

Results in:

```
dyld: Library not loaded: @rpath/libnode.67.dylib
  Referenced from: /Users/rubys/git/node-shared/out/Release/cctest
  Reason: image not found
make: *** [cctest] Abort trap: 6
```

This change adds the loader path to the runtime path for the `cctest` executable.

Backport-PR-URL: #25681
PR-URL: #23168
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants