Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark some flakes #23208

Merged
merged 1 commit into from
Oct 2, 2018
Merged

test: mark some flakes #23208

merged 1 commit into from
Oct 2, 2018

Conversation

refack
Copy link
Contributor

@refack refack commented Oct 1, 2018

parallel:

sequential:

and update some references

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@refack refack added test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Oct 1, 2018
@refack
Copy link
Contributor Author

refack commented Oct 1, 2018

https://ci.nodejs.org/job/node-test-pull-request/17571/

/CC @nodejs/testing

If this passes CI I would like to fast-track. Please upvote if you approve.

@refack
Copy link
Contributor Author

refack commented Oct 2, 2018

@refack
Copy link
Contributor Author

refack commented Oct 2, 2018

Ci shows 1 new arm flake test-http-end-throw-socket-handling #23221
But let's see how often it shows up

PR-URL: nodejs#23208
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@refack refack merged commit 1d56ad0 into nodejs:master Oct 2, 2018
@refack
Copy link
Contributor Author

refack commented Oct 2, 2018

Fast-track landed in 1d56ad0 with 5 Approvals and 3 explicit up-votes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants