Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update ESLint to 5.8.0 #23904

Closed
wants to merge 1 commit into from
Closed

tools: update ESLint to 5.8.0 #23904

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Oct 26, 2018

Update ESLint to 5.8.0.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Update ESLint to 5.8.0.
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 26, 2018
@jasnell
Copy link
Member

jasnell commented Oct 26, 2018

Rubber stamp lgtm

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@Trott
Copy link
Member

Trott commented Oct 26, 2018

Look at that beautiful tiny diff! Only 33 files!

@Trott
Copy link
Member

Trott commented Oct 26, 2018

Seems fast-trackable but I know @cjihrig is not big on using fast-track when not necessary, so I'll hold back unless he requests it....

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 28, 2018
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@danbev
Copy link
Contributor

danbev commented Oct 29, 2018

Landed in 2f1c356.

@danbev danbev closed this Oct 29, 2018
danbev pushed a commit that referenced this pull request Oct 29, 2018
Update ESLint to 5.8.0.

PR-URL: #23904
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@cjihrig cjihrig deleted the eslint branch October 29, 2018 11:44
targos pushed a commit that referenced this pull request Nov 1, 2018
Update ESLint to 5.8.0.

PR-URL: #23904
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@MylesBorins
Copy link
Contributor

Would someone be able to backport the upgraded linter to 8.x

MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
Update ESLint to 5.8.0.

PR-URL: #23904
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
rvagg pushed a commit that referenced this pull request Nov 28, 2018
Update ESLint to 5.8.0.

PR-URL: #23904
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
Update ESLint to 5.8.0.

PR-URL: #23904
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants