Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for _setSimultaneousAccepts() #24180

Closed
wants to merge 1 commit into from
Closed

test: add test for _setSimultaneousAccepts() #24180

wants to merge 1 commit into from

Conversation

melikhov-dev
Copy link
Contributor

Add a test case that verifies that calling the _setSimultaneousAccepts()
function twice does not trigger the deprecation warning twice.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax addaleax added net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests. labels Nov 6, 2018
@BridgeAR BridgeAR added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2018
@addaleax
Copy link
Member

@amel-true Could you undo the merge commit here? Our CI doesn’t play well with them, and we don’t allow merge commits in the master branch. If there were conflicts, using git rebase is the better choice (for this project, at least).

@melikhov-dev
Copy link
Contributor Author

@addaleax yep, i removed merge commit

Add a test case that verifies that calling the `_setSimultaneousAccepts()`
function twice does not trigger the deprecation warning twice.
@oyyd
Copy link
Contributor

oyyd commented Nov 12, 2018

@gireeshpunathil
Copy link
Member

[commit message was longer than 72 chars, fixed it while landing ]

landed as 3235d31

thank you @amel-true for the contribution! Wish you great success with continued contribution to this project, if you are further interested please have a look at https://www.nodetodo.org/next-steps

gireeshpunathil pushed a commit that referenced this pull request Nov 13, 2018
Add a test case that verifies that calling _setSimultaneousAccepts()
function twice does not trigger the deprecation warning twice.

PR-URL: #24180
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
Add a test case that verifies that calling _setSimultaneousAccepts()
function twice does not trigger the deprecation warning twice.

PR-URL: nodejs#24180
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants