test: add tests for Socket.setNoDelay #24250
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for the Socket.setNoDelay function. The tests use the
handle
option when creating a socket so that the function can be tested without having to rely on any underlying transport layer which could result in a flakey test (platform/timing dependent).I wasn't able to figure out how to test the case whereby
setNoDelay
is called before the socket connects - suggestions welcome here.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes