Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: pre-generate data set for URL benchmarks and use WPT test data #24302

Closed
wants to merge 3 commits into from
Closed

benchmark: pre-generate data set for URL benchmarks and use WPT test data #24302

wants to merge 3 commits into from

Commits on Nov 11, 2018

  1. benchmark: pre-generate data set for URL benchmarks 

    This patch:

- Introduces `common.bakeUrlData` which can be used to pre-generate
  the data set for the URL benchmarks to loop through instead of
  looping over a constant.
- Add the option to use WPT data in benchmarks for better diversity
  in the input
- Add the option to benchmark URL parsing with base URLs (whatwg only)
- Moves the data in `benchmark/fixtures/url-inputs.js` to
  `benchmark/common.js`
    @joyeecheung
    joyeecheung committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    c096557 View commit details
    Browse the repository at this point in the history

  2. benchmark: support URL inputs in create-clientrequest 

    This patch adds the option in the create-clientrequest benchmark
to accept URL inputs (as strings or as URL objects) so we can
measure the impact of URL parsing in a more sophisticated use case.
    @joyeecheung
    joyeecheung committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    1ae8ab6 View commit details
    Browse the repository at this point in the history

  3. fixup! benchmark: support URL inputs in create-clientrequest

    @joyeecheung
    joyeecheung committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    d6f9f89 View commit details
    Browse the repository at this point in the history