-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: fix c++ code coverage on macOS #24520
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@refack sadly an error occured when I tried to trigger a build :( |
nodejs-github-bot
added
the
build
Issues and PRs related to build files or the CI.
label
Nov 20, 2018
2 tasks
refack
added
macos
Issues and PRs related to the macOS platform / OSX.
coverage
Issues and PRs related to native coverage support.
labels
Nov 20, 2018
addaleax
approved these changes
Nov 20, 2018
/CC @nodejs/build-files @nodejs/gyp |
I tested this on https://ci.nodejs.org/computer/test-macstadium-macos10.12-x64-1/, and it builds and links But I get this from
P.S. it's actually just the node binary:
|
/CC @nodejs/build-files @nodejs/gyp (CI had just a flake) |
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19111/ |
PR-URL: nodejs#24520 Reviewed-By: Anna Henningsen <[email protected]>
Trott
force-pushed
the
fixmaccppcoverage
branch
from
December 1, 2018 15:22
2818472
to
eb6741b
Compare
Landed in eb6741b |
BridgeAR
pushed a commit
that referenced
this pull request
Dec 5, 2018
PR-URL: #24520 Reviewed-By: Anna Henningsen <[email protected]>
This was referenced Dec 7, 2018
refack
added a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24520 Reviewed-By: Anna Henningsen <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
PR-URL: #24520 Reviewed-By: Anna Henningsen <[email protected]>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
PR-URL: #24520 Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #24004
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes