Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: removed third argument in assert.strictEqual() in test/addons-napi/test_env_sharing/test.js #24584

Closed

Conversation

susantruong
Copy link
Contributor

@susantruong susantruong commented Nov 24, 2018

I am new to Node. I followed this Node Todo to start working on this nodejs project. Also, I followed the instruction Building Node.js on supported platforms to build and run the test before submitting this PR.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes

@nodejs-github-bot nodejs-github-bot added node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Nov 24, 2018
@susantruong susantruong force-pushed the removeThirdArg-test-env-sharing branch from 1de4476 to 89736f3 Compare November 24, 2018 00:58
@Trott
Copy link
Member

Trott commented Nov 24, 2018

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 24, 2018
@Trott
Copy link
Member

Trott commented Nov 24, 2018

Collaborators, 👍 here to fast-track.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 24, 2018
@Trott
Copy link
Member

Trott commented Nov 24, 2018

'N-API environment pointers in two different modules have ' +
'the same value');
// N-API environment pointers in two different modules have the same value

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

nit: line no. 9 can be removed, as the comment is related to assert.strictEqual

@Trott
Copy link
Member

Trott commented Nov 25, 2018

@susantruong susantruong force-pushed the removeThirdArg-test-env-sharing branch from 0c1b3a5 to a292879 Compare November 25, 2018 16:20
@susantruong
Copy link
Contributor Author

I already fixed the commit message and all checks have passed.

@susantruong
Copy link
Contributor Author

@Trott Would you please grant me the overall/read permission?

@susantruong
Copy link
Contributor Author

@Trott You gave me the link about CI, but I couldn't view it.

@Trott
Copy link
Member

Trott commented Nov 27, 2018

@Trott You gave me the link about CI, but I couldn't view it.

It's locked down right now for a security release. It will be available again in a few hours.

@Trott
Copy link
Member

Trott commented Nov 28, 2018

@Trott
Copy link
Member

Trott commented Nov 28, 2018

@Trott
Copy link
Member

Trott commented Nov 28, 2018

@Trott Trott removed the fast-track PRs that do not need to wait for 48 hours to land. label Nov 28, 2018
@Trott
Copy link
Member

Trott commented Nov 28, 2018

Landed in 1066b68.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 28, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 28, 2018
PR-URL: nodejs#24584
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Nov 28, 2018
PR-URL: #24584
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
4 tasks
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
PR-URL: nodejs#24584
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
PR-URL: #24584
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
rvagg pushed a commit that referenced this pull request Feb 28, 2019
PR-URL: #24584
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants