Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: remove duplicated noop function #24770

Closed
wants to merge 1 commit into from
Closed

lib: remove duplicated noop function #24770

wants to merge 1 commit into from

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Dec 1, 2018

We have a noop function outside the if statement in the line 609 :)

node/lib/internal/bootstrap/node.js

Line 609 in eb6741b

function noop() {}

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
Copy link
Member

addaleax commented Dec 1, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19122/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 1, 2018
@Trott
Copy link
Member

Trott commented Dec 4, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19171/

@Trott
Copy link
Member

Trott commented Dec 4, 2018

Needs a rebase.

@Trott Trott removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 4, 2018
@ZYSzys
Copy link
Member Author

ZYSzys commented Dec 4, 2018

@Trott Done, needs CI again ?

@danbev
Copy link
Contributor

danbev commented Dec 4, 2018

Re-based CI: https://ci.nodejs.org/job/node-test-pull-request/19176/

@addaleax
Copy link
Member

addaleax commented Dec 4, 2018

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19185/

@addaleax addaleax added lib / src Issues and PRs related to general changes in the lib or src directory. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 4, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 4, 2018
@ZYSzys @Trott
lib: remove duplicated noop function
a89b873 
PR-URL: nodejs#24770
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
@Trott
Copy link
Member

Trott commented Dec 4, 2018

Landed in a89b873`

@Trott Trott closed this Dec 4, 2018
@ZYSzys ZYSzys deleted the bootstrap branch December 4, 2018 15:04
@joyeecheung joyeecheung mentioned this pull request Dec 5, 2018
Closed
BridgeAR pushed a commit that referenced this pull request Dec 5, 2018
@ZYSzys @BridgeAR
lib: remove duplicated noop function
1ec4f8d 
PR-URL: #24770
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Jan 11, 2019
@ZYSzys @joyeecheung
lib: remove duplicated noop function
373bbe7 
PR-URL: nodejs#24770
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
addaleax pushed a commit that referenced this pull request Jan 14, 2019
@ZYSzys @addaleax
lib: remove duplicated noop function
87a58be 
PR-URL: #24770
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>

Backport-PR-URL: #25446
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@ZYSzys @refack
lib: remove duplicated noop function
8c366ec 
PR-URL: nodejs#24770
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@ZYSzys @BridgeAR
lib: remove duplicated noop function
ca7888d 
PR-URL: nodejs#24770
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>

Backport-PR-URL: nodejs#25446
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@starkwang starkwang starkwang approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ZYSzys @addaleax @Trott @danbev @lpinca @cjihrig @BridgeAR @starkwang @BethGriggs