Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix added version of randomFill+randomFillSync #24812

Closed
wants to merge 1 commit into from

Conversation

watson
Copy link
Member

@watson watson commented Dec 3, 2018

crypto.randomFill and crypto.randomFillSync was backported to Node.js 6.13.0 but the documentation wasn't updated. So the documentation still says that this was added in v7.10.0.

This PR updates that to say v6.13.0, but I'm honestly not really sure if that's the best solution. Because it of course means that it wasn't there between version 7.0.0 and 7.9.0.

Possible solutions:

  • Don't care because 7.x isn't EoL
  • Add a row to the changes: section saying that it wasn't there between 7.0.0 and 7.9.0
  • Update the yaml parser to support that a function be added in more than one different major

@nodejs/documentation What do you think?

Update: Changed the PR according to #24812 (comment)

Checklist

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Dec 3, 2018
@vsemozhetbyt
Copy link
Contributor

It seems we already support multiple versions here. See code changes and test examples in 00ffa33, in particular test/fixtures/doc_with_yaml.md.

@watson
Copy link
Member Author

watson commented Dec 3, 2018

@vsemozhetbyt updated with both versions in the added: section

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 3, 2018
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@watson watson self-assigned this Dec 3, 2018
@devsnek devsnek added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 3, 2018
@watson
Copy link
Member Author

watson commented Dec 3, 2018

Landed in fa19ce9

@watson watson closed this Dec 3, 2018
@watson watson deleted the random-fill branch December 3, 2018 19:59
watson added a commit that referenced this pull request Dec 3, 2018
PR-URL: #24812
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
BridgeAR pushed a commit that referenced this pull request Dec 5, 2018
PR-URL: #24812
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
4 tasks
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
PR-URL: nodejs#24812
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
PR-URL: #24812
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
PR-URL: #24812
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
PR-URL: #24812
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants