Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase error information in test-cli-syntax-* #25021

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 13, 2018

If there is an error, but not the error code the test expects, display
more information about the error.

Collaborators, please 👍 to fast-track.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

If there is an error, but not the error code the test expects, display
more information about the error.
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 13, 2018
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 13, 2018
@Trott
Copy link
Member Author

Trott commented Dec 13, 2018

@richardlau
Copy link
Member

Extra output can be seen in the AIX run of this PR (it's green because the tests are marked flaky). I'm not sure it helps much (but totally not blocking this from landing).

@Trott
Copy link
Member Author

Trott commented Dec 14, 2018

@Trott
Copy link
Member Author

Trott commented Dec 14, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19496/ ✔️

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 14, 2018
@Trott
Copy link
Member Author

Trott commented Dec 14, 2018

Landed in 914c494

@Trott Trott closed this Dec 14, 2018
Trott added a commit that referenced this pull request Dec 14, 2018
If there is an error, but not the error code the test expects, display
more information about the error.

PR-URL: #25021
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 18, 2018
If there is an error, but not the error code the test expects, display
more information about the error.

PR-URL: #25021
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
If there is an error, but not the error code the test expects, display
more information about the error.

PR-URL: nodejs#25021
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 8, 2019
If there is an error, but not the error code the test expects, display
more information about the error.

PR-URL: #25021
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
@Trott Trott deleted the test-cli-more-info branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants