Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark test-cli-node-options flaky on arm #25032

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 14, 2018

Collaborators, 👍 here to fast-track.

Refs: #25028

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott Trott added test Issues and PRs related to the tests. arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Dec 14, 2018
@Trott
Copy link
Member Author

Trott commented Dec 14, 2018

@Trott
Copy link
Member Author

Trott commented Dec 14, 2018

@Trott
Copy link
Member Author

Trott commented Dec 14, 2018

ARM failure was a different pair of tests that I believe is infra-related. Affected host as been taken offline. Rebuild: https://ci.nodejs.org/job/node-test-commit-arm/20816/ ✔️

Rest of CI is good, so if that passes, this can land.

@Trott
Copy link
Member Author

Trott commented Dec 14, 2018

Landed in adf5083

@Trott Trott closed this Dec 14, 2018
Trott added a commit to Trott/io.js that referenced this pull request Dec 14, 2018
Refs: nodejs#25028

PR-URL: nodejs#25032
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 18, 2018
Refs: #25028

PR-URL: #25032
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
Refs: nodejs#25028

PR-URL: nodejs#25032
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 29, 2019
Refs: #25028

PR-URL: #25032
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@codebytere codebytere mentioned this pull request Jan 29, 2019
codebytere pushed a commit that referenced this pull request Jan 29, 2019
Refs: #25028

PR-URL: #25032
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
codebytere pushed a commit that referenced this pull request Jan 29, 2019
Refs: #25028

PR-URL: #25032
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm Issues and PRs related to the ARM platform. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants