Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: format() now formats bigint and booleans #25046

Closed
wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

This is necessary to distinguish them from other data types.

I also added a test for formatWithOptions which was untested so far and which was necessary to actually see which types are passed through to inspect.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

This is necessary to distinguish them from other data types.
@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Dec 14, 2018
@BridgeAR
Copy link
Member Author

BridgeAR commented Dec 16, 2018

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 16, 2018
@Trott
Copy link
Member

Trott commented Dec 17, 2018

@nodejs/util This could use another review.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@antsmartian antsmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

BridgeAR added a commit to BridgeAR/node that referenced this pull request Dec 19, 2018
This is necessary to distinguish them from other data types.

PR-URL: nodejs#25046
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@BridgeAR
Copy link
Member Author

Landed in 0f58ae3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants