Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: make Buffer binding and prototype setup more straight-forward #25292

Closed
wants to merge 2 commits into from
Closed

buffer: make Buffer binding and prototype setup more straight-forward #25292

wants to merge 2 commits into from
+120 −95

Commits on Dec 31, 2018

  1. buffer: move initialization of buffer prototype into node.js 

    Instead of exposing it in `lib/internal/buffer.js` after deleting
it from the binding and then do the initialization in
`lib/buffer.js`, which results in an implicit dependency on
the order in which these modules are loaded.
    @joyeecheung
    joyeecheung committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    fa6b492 View commit details
    Browse the repository at this point in the history

  2. buffer: move Buffer prototype wiring into internal/buffer.js 

    Instead of exposing the Buffer prototype methods through an
object in `internal/buffer.js` and then iterating over it
to put the methods on the prototype, create a function
in `internal/buffer.js` to do this.

Also moves the creaton of the `FastBuffer` class into
`internal/buffer.js` and expose it directly instead of
writing it onto that module later.
    @joyeecheung
    joyeecheung committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    8d5c144 View commit details
    Browse the repository at this point in the history