Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: update release guide with notes for major releases #25497

Closed
wants to merge 9 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jan 14, 2019

Intended as an initial quick draft.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@jasnell
Copy link
Member Author

jasnell commented Jan 14, 2019

/cc @BethGriggs @nodejs/release

Copy link
Member

@BethGriggs BethGriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was talking offline with @richardlau and he mentioned other steps for major releases such as creating symlinks for dist/latest-v12.x etc. - should that information be captured here too?

@jasnell
Copy link
Member Author

jasnell commented Jan 15, 2019 via email

@codebytere
Copy link
Member

LGTM 👍

@jasnell
Copy link
Member Author

jasnell commented Jan 28, 2019

Ping @nodejs/release

@cjihrig
Copy link
Contributor

cjihrig commented Jan 28, 2019

I believe @BethGriggs and @codebytere both LGTM'ed this, and can review on behalf of the release team.

@jasnell
Copy link
Member Author

jasnell commented Jan 28, 2019

Ah, right lol... I was scanning for green checkmarks not inline LGTMs :-)

@vsemozhetbyt
Copy link
Contributor

Should the TOC be updated?

Copy link
Contributor

@vsemozhetbyt vsemozhetbyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc format LGTM, with some nits.

doc/releases.md Outdated Show resolved Hide resolved
doc/releases.md Outdated Show resolved Hide resolved
doc/releases.md Outdated Show resolved Hide resolved
doc/releases.md Outdated Show resolved Hide resolved
@targos
Copy link
Member

targos commented Feb 5, 2019

Can you add a link to the table of contents?

@BethGriggs
Copy link
Member

(Carrying over some of the conversations from #26844)

@jasnell, rather than cherry-picking around the majors that land on master after the major cut off, would it be possible to gate the major PRs landing in master for those 3-4 weeks? The current guidance around semver majors requiring no objections from TSC + 2 reviews could apply.

No commits should then be out of order - which has happened recently when we have gotten a retrospective request/agreement for a specific major from master to land on vN.x. The final vN.x release would pretty much just be a direct cut of master on the date of the final release candidate, and the commit history of the new release would be parallel with master for the first release.

(I understand that implementing a "semver major freeze on master" process would first require socialisation of the idea and agreement from the various working groups.)

@jasnell
Copy link
Member Author

jasnell commented Apr 4, 2019

The current model was chosen to avoid adding any delay to master branch development. It intentionally puts more burden on the releaser so that there's no need to hold up activity in master. I'd prefer to keep it true to that goal

@targos targos added the meta Issues and PRs related to the general management of the project. label Apr 25, 2019
@richardlau
Copy link
Member

richardlau commented May 12, 2019

Add a post release task to update the altdocs versions? e.g. #27658.

Edit: This will not be required if #27661 lands.

@richardlau
Copy link
Member

LGTM. I was talking offline with @richardlau and he mentioned other steps for major releases such as creating symlinks for dist/latest-v12.x etc. - should that information be captured here too?

For the dist symlinks, e.g. nodejs/nodejs-latest-linker#2, that only currently needs to be done for the first transition to LTS release.

For the first transition to LTS release there's also a test, parallel/test-process-release.js, that needs updating.

doc/releases.md Outdated Show resolved Hide resolved
doc/releases.md Outdated Show resolved Hide resolved
doc/releases.md Outdated Show resolved Hide resolved
doc/releases.md Outdated Show resolved Hide resolved
doc/releases.md Outdated Show resolved Hide resolved
doc/releases.md Outdated Show resolved Hide resolved
doc/releases.md Outdated Show resolved Hide resolved
doc/releases.md Outdated Show resolved Hide resolved
doc/releases.md Outdated Show resolved Hide resolved
doc/releases.md Outdated Show resolved Hide resolved
doc/releases.md Outdated Show resolved Hide resolved
doc/releases.md Outdated Show resolved Hide resolved
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a bunch of suggestions, but I'm A-OK with this without some or all of them. I do think they are all improvements, but mostly only marginal improvements.

@richardlau
Copy link
Member

@nodejs/releasers Does it make sense to land this as-is and then update as necessary?

@BethGriggs

This comment has been minimized.

@BethGriggs
Copy link
Member

BethGriggs pushed a commit that referenced this pull request Sep 6, 2019
Co-Authored-By: jasnell <[email protected]>
Co-Authored-By: Rich Trott <[email protected]>
Co-Authored-By: Beth Griggs <[email protected]>

PR-URL: #25497
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@BethGriggs
Copy link
Member

Landed in 7b350bb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants