Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ensure npm version is not release candidate #25538

Closed
wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

v11.6.0 ended up shipping with an npm version 6.5.0-next.0.
This test should avoid it happening in the future.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 16, 2019
test/parallel/test-npm-version.js Outdated Show resolved Hide resolved
test/parallel/test-npm-version.js Outdated Show resolved Hide resolved
test/parallel/test-npm-version.js Outdated Show resolved Hide resolved
test/parallel/test-npm-version.js Outdated Show resolved Hide resolved
test/parallel/test-npm-version.js Outdated Show resolved Hide resolved
test/parallel/test-npm-version.js Outdated Show resolved Hide resolved
@MylesBorins MylesBorins force-pushed the no-npm-rc branch 2 times, most recently from 3fa37d5 to 0161c61 Compare January 16, 2019 23:15
v11.6.0 ended up shipping with an npm version `6.5.0-next.0`.
This test should avoid it happening in the future.
@MylesBorins
Copy link
Contributor Author

All feedback incorporated. PTAL

@ljharb
Copy link
Member

ljharb commented Jan 17, 2019

(linking to #25311 and #25234)

@MylesBorins
Copy link
Contributor Author

@MylesBorins
Copy link
Contributor Author

Landed in 2e613a9

MylesBorins added a commit that referenced this pull request Jan 18, 2019
v11.6.0 ended up shipping with an npm version `6.5.0-next.0`.
This test should avoid it happening in the future.

PR-URL: #25538
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
);

const pkg = require(npmPathPackageJson);
assert(pkg.version.match(/^\d+\.\d+\.\d+$/),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assert(pkg.version.match(/^\d+\.\d+\.\d+$/),
assert.ok(/^\d+.\d+.\d+$/.test(pkg.version.match),

addaleax pushed a commit that referenced this pull request Jan 23, 2019
v11.6.0 ended up shipping with an npm version `6.5.0-next.0`.
This test should avoid it happening in the future.

PR-URL: #25538
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants