Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: refactor policy code for readability #25629

Closed
wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Simplify a few particularly quirky bits of code, and add
whitespace for readability.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Simplify a few particularly quirky bits of code, and add
whitespace for readability.
@nodejs-github-bot nodejs-github-bot added the process Issues and PRs related to the process subsystem. label Jan 21, 2019
}
} = require('buffer');

const BufferFrom = require('buffer').Buffer.from;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aw i liked this before :(

@antsmartian
Copy link
Contributor

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 24, 2019
@addaleax
Copy link
Member Author

@danbev
Copy link
Contributor

danbev commented Jan 25, 2019

Landed in 0f5c14c.

@danbev danbev closed this Jan 25, 2019
addaleax added a commit that referenced this pull request Jan 28, 2019
Simplify a few particularly quirky bits of code, and add
whitespace for readability.

PR-URL: #25629
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@targos targos mentioned this pull request Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. process Issues and PRs related to the process subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants