doc: revise breaking changes material in COLLABORATOR_GUIDE #25730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove unnecessary paragraph explaining why Current and LTS have stability guarantees that master branch does not. (Leave material explaining what those stability guarantees are.) * Upgrade advisory and passive "Collaborators should take significant care" to more direct "Take significant care".
BethGriggs
approved these changes
Jan 27, 2019
Trott
added
the
author ready
jasnell
approved these changes
Jan 28, 2019
antsmartian
approved these changes
Jan 28, 2019
|
Landed in aa8fcee |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 29, 2019
* Remove unnecessary paragraph explaining why Current and LTS have stability guarantees that master branch does not. (Leave material explaining what those stability guarantees are.) * Upgrade advisory and passive "Collaborators should take significant care" to more direct "Take significant care". PR-URL: nodejs#25730 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jan 29, 2019
* Remove unnecessary paragraph explaining why Current and LTS have stability guarantees that master branch does not. (Leave material explaining what those stability guarantees are.) * Upgrade advisory and passive "Collaborators should take significant care" to more direct "Take significant care". PR-URL: #25730 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 29, 2019
* Remove unnecessary paragraph explaining why Current and LTS have stability guarantees that master branch does not. (Leave material explaining what those stability guarantees are.) * Upgrade advisory and passive "Collaborators should take significant care" to more direct "Take significant care". PR-URL: #25730 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
May 10, 2019
* Remove unnecessary paragraph explaining why Current and LTS have stability guarantees that master branch does not. (Leave material explaining what those stability guarantees are.) * Upgrade advisory and passive "Collaborators should take significant care" to more direct "Take significant care". PR-URL: #25730 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
* Remove unnecessary paragraph explaining why Current and LTS have stability guarantees that master branch does not. (Leave material explaining what those stability guarantees are.) * Upgrade advisory and passive "Collaborators should take significant care" to more direct "Take significant care". PR-URL: #25730 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stability guarantees that master branch does not. (Leave material
explaining what those stability guarantees are.)
care" to more direct "Take significant care".
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes