Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unimplemented method in node_http2.h #25732

Closed

Conversation

gengjiawen
Copy link
Member

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Jan 27, 2019
@danbev
Copy link
Contributor

danbev commented Jan 31, 2019

@gengjiawen
Copy link
Member Author

@danbev can you import this change ? thanks.

@danbev
Copy link
Contributor

danbev commented Feb 4, 2019

Re-run of CI: https://ci.nodejs.org/job/node-test-pull-request/20559/ (✔️)

@targos
Copy link
Member

targos commented Feb 4, 2019

Commit message: s/unimplement/unimplemented/

@gengjiawen gengjiawen changed the title src: remove unimplement method in node_http2.h src: remove unimplemented method in node_http2.h Feb 4, 2019
@gengjiawen
Copy link
Member Author

@targos Fixed. Thanks.

@danbev
Copy link
Contributor

danbev commented Feb 4, 2019

Landed in c6ecbd3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants