Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: split up osVersion and machine values #25755

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 28, 2019

Prior to this commit, on non-Windows platforms, the "osVersion" value was prepended to the "machine" value.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 28, 2019
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also be cool to use uv_os_uname now that we have it, I assume?

@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 29, 2019

It would also be cool to use uv_os_uname now that we have it, I assume?

Yes, I'd like to do that. There are some differences to reconcile, and it would be nice to use it for Windows as well. Definitely something to do before it graduates from experimental, or not at all IMO.

@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 30, 2019

CI: https://ci.nodejs.org/job/node-test-commit/25418/

The linter failed for some reason. Reran it with no changes and it passed: https://ci.nodejs.org/job/node-test-linter/25296/

EDIT: All green CI: https://ci.nodejs.org/job/node-test-commit/25464/

Prior to this commit, on non-Windows platforms, the "osVersion"
value was prepended to the "machine" value.

PR-URL: nodejs#25755
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@cjihrig cjihrig merged commit c233546 into nodejs:master Jan 30, 2019
@cjihrig cjihrig deleted the machine branch January 30, 2019 21:42
addaleax pushed a commit that referenced this pull request Jan 30, 2019
Prior to this commit, on non-Windows platforms, the "osVersion"
value was prepended to the "machine" value.

PR-URL: #25755
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@richardlau richardlau added the report Issues and PRs related to process.report. label Jan 31, 2019
cjihrig added a commit to cjihrig/node that referenced this pull request Feb 2, 2019
PR-URL: nodejs#25855
Refs: nodejs#25755
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 3, 2019
PR-URL: #25855
Refs: #25755
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@targos targos mentioned this pull request Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants