Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: make test.py Python 3 compatible #25767

Closed

Conversation

thefourtheye
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

cc @nodejs/python @cclauss @gengjiawen

@thefourtheye thefourtheye added tools Issues and PRs related to the tools directory. python PRs and issues that require attention from people who are familiar with Python. labels Jan 28, 2019
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 28, 2019
@thefourtheye thefourtheye mentioned this pull request Jan 28, 2019
4 tasks
Copy link
Member

@gengjiawen gengjiawen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job.

tools/test.py Show resolved Hide resolved
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

tools/test.py Outdated Show resolved Hide resolved
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danbev
Copy link
Contributor

danbev commented Feb 1, 2019

@addaleax
Copy link
Member

addaleax commented Feb 1, 2019

Landed in 5e0a326

(Side note: It’s a shame that git node land doesn’t automatically pick up non-collaborator approvals :/)

@addaleax addaleax closed this Feb 1, 2019
addaleax pushed a commit that referenced this pull request Feb 1, 2019
PR-URL: #25767
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: cclauss <[email protected]>
Reviewed-By: gengjiawen <[email protected]>
@richardlau
Copy link
Member

(Side note: It’s a shame that git node land doesn’t automatically pick up non-collaborator approvals :/)

Isn't that by design?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python PRs and issues that require attention from people who are familiar with Python. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants