-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: migrate round_robin_handle to internal assert #26047
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
cluster
Issues and PRs related to the cluster subsystem.
label
Feb 11, 2019
mscdex
reviewed
Feb 11, 2019
cjihrig
approved these changes
Feb 11, 2019
lpinca
approved these changes
Feb 11, 2019
Trott
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Feb 12, 2019
antsmartian
approved these changes
Feb 12, 2019
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/20741/ |
jasnell
approved these changes
Feb 12, 2019
bnoordhuis
reviewed
Feb 12, 2019
Use smaller internal assert module for round_robin_handle.js.
Trott
force-pushed
the
internal-assert-for-round-robin
branch
from
February 13, 2019 00:47
f3a03ff
to
8491298
Compare
OK, this now adds a tiny PTAL. Thanks. Pinging people who approved previously for a re-review: @cjihrig @antsmartian @jasnell @lpinca And pinging folks who had comments that I believe this change now addresses: @mscdex @bnoordhuis |
Trott
removed
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Feb 13, 2019
Still LGTM. |
Trott
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Feb 13, 2019
addaleax
pushed a commit
that referenced
this pull request
Feb 13, 2019
PR-URL: #26047 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Feb 13, 2019
Use smaller internal assert module for round_robin_handle.js. PR-URL: #26047 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Feb 14, 2019
PR-URL: #26047 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Feb 14, 2019
Use smaller internal assert module for round_robin_handle.js. PR-URL: #26047 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
cluster
Issues and PRs related to the cluster subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use smaller internal assert module for round_robin_handle.js.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes